Skip to content

chore(scripts): Run CI on x86 as well#58

Merged
resin-io-modules-versionbot[bot] merged 2 commits into
masterfrom
prebuild-x86
Oct 19, 2017
Merged

chore(scripts): Run CI on x86 as well#58
resin-io-modules-versionbot[bot] merged 2 commits into
masterfrom
prebuild-x86

Conversation

@jhermsmeier
Copy link
Copy Markdown
Contributor

@jhermsmeier jhermsmeier commented Oct 18, 2017

As previous efforts have shown, the --arch flags on prebuild
didn't do the expected, and this now runs CI builds on x86 as well.

Change-Type: patch
Connects To: #57

@lurch
Copy link
Copy Markdown
Contributor

lurch commented Oct 18, 2017

Just out of curiosity, I did a quick search in the prebuild repo, and AFAICT the arch is only actually used when constructing the output filename :-/

@lurch
Copy link
Copy Markdown
Contributor

lurch commented Oct 18, 2017

Do we need to restrict this to not run x86 builds on OSX? See https://github.com/resin-io/etcher/blob/master/.travis.yml for comparison.

@lurch
Copy link
Copy Markdown
Contributor

lurch commented Oct 18, 2017

Wow, such combinations! https://github.com/resin-io-modules/mountutils/releases/tag/v1.3.4
(but it seems like even that list isn't quite complete, as it's missing win32 x86 builds). Reminds me of @jviotti 's Contracts stuff! 😆

As previous efforts have shown, the `--arch` flags on `prebuild`
didn't do the expected, and this now runs CI builds on x86 as well.

Change-Type: patch
@jhermsmeier
Copy link
Copy Markdown
Contributor Author

jhermsmeier commented Oct 19, 2017

and AFAICT the arch is only actually used when constructing the output filename :-/

Yeah, also saw that (a bit too late) :'(

Do we need to restrict this to not run x86 builds on OSX?

Whooops, fixed!

but it seems like even that list isn't quite complete, as it's missing win32 x86 builds

Maybe this time around -.-

@lurch
Copy link
Copy Markdown
Contributor

lurch commented Oct 19, 2017

Maybe this time around -.-

Fingers crossed... :-)

@resin-io-modules-versionbot
Copy link
Copy Markdown
Contributor

VersionBot failed to carry out a status check for the above pull request here: #58. The reason for this is:
3 of 6 required status checks have not succeeded: 2 expected and 1 pending.
Please carry out relevant changes or alert an appropriate admin.

@lurch
Copy link
Copy Markdown
Contributor

lurch commented Oct 19, 2017

*sigh* https://travis-ci.org/resin-io-modules/mountutils/builds/290161226 claims it's run Linux x86 and Linux x64 builds, and https://ci.appveyor.com/project/resin-io/mountutils/build/1.0.328 claims it's run Windows x86 and x64 builds, but https://github.com/resin-io-modules/mountutils/releases shows no x86 builds for v1.3.5 😢

Hmmm, and https://ci.appveyor.com/project/resin-io/mountutils/build/1.0.328/job/f74jrkub2sst6l7h says TARGET_ARCH=x86 but then:

Install-Product node $env:nodejs_version x64
Uninstalling node 4.8.4 (x86)...
Installing node 6.11.3 (x64)...

and later on

prebuild info begin Prebuild version 6.2.2
prebuild info build Preparing to prebuild mountutils@1.3.5 for node 4.6.1 on win32-x64 using node-gyp

Why does this have to be so tricky? 😖

.....

Hmmm, just checked the Appveyor docs, and it says we need to use platform to change the CPU? Does this also mean that our Appveyor x86 builds on Etcher aren't set up correctly, @jviotti ?

I couldn't find anything in the Travis docs about x86 builds (although I found travis-ci/travis-ci#986 ) and it looks like our Linux x86 builds of Etcher rely purely on running a 32-bit docker container on a 64-bit host.

Sorry @jhermsmeier , I didn't realise such a "simple request" #57 (comment) would turn out to be so complicated :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants