chore(scripts): Run CI on x86 as well#58
Conversation
3d3373f to
5ead911
Compare
|
Just out of curiosity, I did a quick search in the |
|
Do we need to restrict this to not run x86 builds on OSX? See https://github.com/resin-io/etcher/blob/master/.travis.yml for comparison. |
|
Wow, such combinations! https://github.com/resin-io-modules/mountutils/releases/tag/v1.3.4 |
As previous efforts have shown, the `--arch` flags on `prebuild` didn't do the expected, and this now runs CI builds on x86 as well. Change-Type: patch
5ead911 to
6cc1cf9
Compare
Yeah, also saw that (a bit too late) :'(
Whooops, fixed!
Maybe this time around -.- |
Fingers crossed... :-) |
|
VersionBot failed to carry out a status check for the above pull request here: #58. The reason for this is: |
|
*sigh* https://travis-ci.org/resin-io-modules/mountutils/builds/290161226 claims it's run Linux x86 and Linux x64 builds, and https://ci.appveyor.com/project/resin-io/mountutils/build/1.0.328 claims it's run Windows x86 and x64 builds, but https://github.com/resin-io-modules/mountutils/releases shows no x86 builds for v1.3.5 😢 Hmmm, and https://ci.appveyor.com/project/resin-io/mountutils/build/1.0.328/job/f74jrkub2sst6l7h says and later on Why does this have to be so tricky? 😖 ..... Hmmm, just checked the Appveyor docs, and it says we need to use I couldn't find anything in the Travis docs about x86 builds (although I found travis-ci/travis-ci#986 ) and it looks like our Linux x86 builds of Etcher rely purely on running a 32-bit docker container on a 64-bit host. Sorry @jhermsmeier , I didn't realise such a "simple request" #57 (comment) would turn out to be so complicated :-/ |
As previous efforts have shown, the
--archflags onprebuilddidn't do the expected, and this now runs CI builds on x86 as well.
Change-Type: patch
Connects To: #57