Skip to content

fix(delete-pr-preview command): only hash branch name inside delete preview command #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2020
Merged

fix(delete-pr-preview command): only hash branch name inside delete preview command #101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions gitopscli/commands/delete_pr_preview.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import hashlib
import logging
import os
import uuid
Expand Down Expand Up @@ -41,7 +40,6 @@ def delete_pr_preview_command(
)

apps_git.checkout(branch)
preview_id = hashlib.sha256(branch.encode("utf-8")).hexdigest()[:8]
logging.info("App repo branch %s checkout successful", branch)
try:
gitops_config = GitOpsConfig(apps_git.get_full_file_path(".gitops.config.yaml"))
Expand Down Expand Up @@ -73,7 +71,7 @@ def delete_pr_preview_command(
repository_name,
git_provider,
git_provider_url,
preview_id,
branch,
)

finally:
Expand Down