fix: dark mode for FilamentGroupPopup#10822
Open
BenJule wants to merge 3 commits into
Open
Conversation
This was referenced May 20, 2026
Closed
BenJule
force-pushed
the
fix/10530-filament-group-popup-dark-mode
branch
from
3393248 to
a69c7a0
Compare
The upstream build_all.yml only listed 'main' as a push trigger. BenJule/BambuStudio uses 'master' as its default branch, so CI never fired on fork-local pushes. Adding 'master' alongside 'main' makes the full multi-platform build run when master is updated.
The filament grouping popup always rendered with a hardcoded white background (#FFFFFF) regardless of dark mode. Replace the static BackGroundColor constant with bg_color() / label_clr() runtime helpers that return the correct dark-mode colors at call time, including the SmartFilament section border and background. Closes bambulab#10530
BenJule
force-pushed
the
fix/10530-filament-group-popup-dark-mode
branch
from
a69c7a0 to
e3e6505
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The filament grouping popup in the Preview tab always rendered with a hardcoded white (
#FFFFFF) background regardless of dark mode. The staticBackGroundColorconstant was a compile-time value thatUpdateDarkUIWinalone could not reliably remap.Replaced with
bg_color()/label_clr()runtime helpers that return the correct colors at call time (#2D2D31background,#EFEFF0text in dark mode), including the SmartFilament section border and background.Test plan
Closes #10530