fix: 'Support for ABS' shown as 'ABS' in filament grouping dialog#10829
Open
BenJule wants to merge 4 commits into
Open
fix: 'Support for ABS' shown as 'ABS' in filament grouping dialog#10829BenJule wants to merge 4 commits into
BenJule wants to merge 4 commits into
Conversation
This was referenced May 20, 2026
Closed
BenJule
force-pushed
the
fix/10773-support-filament-name-grouping
branch
from
6041088 to
ef24b0e
Compare
The upstream build_all.yml only listed 'main' as a push trigger. BenJule/BambuStudio uses 'master' as its default branch, so CI never fired on fork-local pushes. Adding 'master' alongside 'main' makes the full multi-platform build run when master is updated.
…ambulab#10773) Two root causes: 1. FilamentMapDialog read raw filament_type config values directly. Support filaments store their base type ("ABS") there, making them indistinguishable from regular ABS. Replace with a loop over get_filament_type() so the display name ("Sup.ABS") is used. 2. get_filament_type() handled PLA-S and PA-S in the filament_id- present branch but was missing the ABS-S case, causing it to fall through to the raw "ABS" return value. Closes bambulab#10773
…alog
When a project uses both a regular filament (e.g. ABS) and its support
variant (e.g. Support for ABS), both presets share the same filament_type
value ('ABS'). The FilamentMapDialog therefore displayed two identical
'ABS' labels, making it impossible to distinguish the two slots.
Use the filament_is_support config flag (same convention already used by
Preset::get_filament_type()) to prepend 'Sup.' to the type string before
passing it to the grouping dialog, so the labels read 'ABS' and 'Sup.ABS'.
BenJule
force-pushed
the
fix/10773-support-filament-name-grouping
branch
from
ef24b0e to
049f233
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a project loads both a regular filament (e.g. ABS) and its support variant (e.g. Support for ABS), the filament grouping dialog shows two identical ABS labels, making it impossible to distinguish the two slots.
Root cause
Both preset types store
filament_type = "ABS"in config. Two separate code paths read the raw values without checkingfilament_is_support:FilamentMapDialog.cpp(try_pop_up_before_slice) — dialog triggered before slicingPlater.cpp(open_filament_map_setting_dialog) — dialog opened manuallyFix
FilamentMapDialog.cpp: Replace the direct option read withget_filament_type(), which returns the display string including theSup.prefix for support filaments.Plater.cpp: After reading rawfilament_typevalues, prepend"Sup."for any slot whose preset hasfilament_is_support = true— matching the convention used byget_filament_type().Test plan
Fixes #10773