Skip to content

#52 Added isNaNStrict function and updated isEqual to use it#53

Merged
bameyrick merged 1 commit intomasterfrom
52-is-equal-nan
Jan 5, 2023
Merged

#52 Added isNaNStrict function and updated isEqual to use it#53
bameyrick merged 1 commit intomasterfrom
52-is-equal-nan

Conversation

@bameyrick
Copy link
Owner

@bameyrick bameyrick commented Jan 5, 2023

Resolves #52

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (83f0f3b) compared to base (0fb8ee3).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #53   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           62        63    +1     
  Lines          359       364    +5     
  Branches        48        49    +1     
=========================================
+ Hits           359       364    +5     
Impacted Files Coverage Δ
src/index.ts 100.00% <100.00%> (ø)
src/isEqual.ts 100.00% <100.00%> (ø)
src/isNaNStrict.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bameyrick bameyrick merged commit c0f7617 into master Jan 5, 2023
@bameyrick bameyrick deleted the 52-is-equal-nan branch January 5, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

isEqual returns false when a and be are NaN

1 participant