fix: dependencies#100
Merged
pierrezimmermannbam merged 2 commits intomainfrom Nov 15, 2023
Merged
Conversation
github-actions
Bot
added
the
no-conventional-pr-name
github-actions
Bot
removed
the
no-conventional-pr-name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had a bug on Safran because the plugin has a version of @typescript-eslint/parser that does not match the one we have on our project. It was a dependency but it should be a peer dep like other packages.
There were other issues, some peer deps were not the same as dev deps, this is because renovate updated some dev deps but did not update peer deps as well. Finally some peer deps were not included in dev deps (a11y plugin) which was fine because it's not tested at all but it would have been problematic otherwise