fix(eslint-plugin): reinstating require-named-effects#86
Merged
Conversation
JulienIzz
force-pushed
the
fix/reinstate-required-named-effect
branch
from
4eaa981 to
7bad3dd
Compare
EveJulliard
reviewed
Oct 18, 2023
EveJulliard
reviewed
Oct 18, 2023
EveJulliard
reviewed
Oct 18, 2023
EveJulliard
reviewed
Oct 18, 2023
EveJulliard
approved these changes
Oct 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR aims to clean the last versions which deleted custom rules.
The objective was to revert the following commits :
4c81100 (fix: remove useless required line in index (#84))
e6fcf3b (revert(eslint-plugin): delete custom rules (#81))
To do this I reverted the two commits then reworked in the same order as MR#81 but without removing require-named-effect rules.
I also added the rules to example-app to allow testing.
Test protocol :