Skip to content

Add in Bfrescoxpro package#14

Merged
jared321 merged 14 commits intomainfrom
13AddPro
Oct 9, 2025
Merged

Add in Bfrescoxpro package#14
jared321 merged 14 commits intomainfrom
13AddPro

Conversation

@jared321
Copy link
Contributor

@jared321 jared321 commented Oct 8, 2025

PR Self-review

  • Carefully review all changes made in branch
  • Check that all new tox tasks pass and are running as expected
    • Intentionally broke tests and confirmed correct reporting of error including nonzero error code
    • Intentionally broke style and confirmed correct reporting of error including nonzero error code
  • Install package directly from local clone & test
    • Started clean (i.e., removed bin, build, and meson intermediate folders)
    • macOS with GCC 15.2.0/OpenMP 4.5 (homebrew) and Open MPI 5.0.8 (homebrew)
    • Reviewed build log carefully. Correct MPI and OpenMP flags. Correct macOS/ARM64 link flags.
    • Confirm MPI+OpenMPI but no external LAPACK or core
    • Confirm correct content in build_info.csv
    • Confirm that test suite can be run on installation through Python interpreter
    • Check information and print_information
  • Install package directly from local clone in editable mode & test
    • Started clean (i.e., removed bin, build, and meson intermediate folders)
    • macOS with GCC 15.2.0/OpenMP 4.5 (homebrew) and Open MPI 5.0.8 (homebrew)
    • Reviewed build log carefully. Correct MPI and OpenMP flags. Correct macOS/ARM64 link flags.
    • Confirm MPI+OpenMP but no external LAPACK or core
    • Confirm correct content in build_info.csv
    • Confirm that test suite can be run on installation through Python interpreter
    • Check information and print_information
    • Intentionally break test in local clone and see that test immediately fails to confirm editable mode
  • Build package from source distribution manually, install, & test
    • Started clean (i.e., removed bin, build, and meson intermediate folders)
    • macOS with GCC 15.2.0/OpenMP 4.5 (homebrew) and Open MPI 5.0.8 (homebrew)
    • Confirm correct, minimal contents including LICENSE
    • Reviewed package and install logs carefully. Correct MPI and OpenMP flags. Correct macOS/ARM64 link flags.
    • Confirm MPI+OpenMP but to external LAPACK or core
    • Confirm correct content in build_info.csv
    • Confirm that test suite can be run on installation through Python interpreter
    • Check information and print_information
    • Repeated on cluster using Intel OneAPI 2023.2.1/OpenMP 5.0-revision1 (modules) and Intel Open MPI 4.1.6 (modules)
  • Check that version information is created correctly (v0.0.0 since no tags yet)
    • In wheel and source distribution names
    • python -m pydoc bfrescoxpro
    • bfrescox.__version__
    • python -m pip list and python -m pip show bfrescoxpro
  • On one machine check that BFRESCOX_* env vars are working as expected
    • Started clean (i.e., removed bin, build, and meson intermediate folders)
    • See that all three possible values induce the expected behavior. My compilers all support OpenMP, so I can't check BFRESCOX_USE_OMP=auto and =enabled completely. Failed on bad feature value.
    • Check build_info.csv manually
    • Check information and print_information output manually
    • Confirm that test suite can be run on installation through Python interpreter
    • No need to check Lapack and Corex functionality since not official
  • Review new content in rendered RTD docs in PR
  • Intentionally break code/tests to confirm that new job & action fail as expected
    • testing and code coverage measurements on broken test
    • flake8 on bad style
  • Spot check logs in new job & action
  • Download new code coverage artifact and review
  • Check merging of two package coverage results in CodeCov
  • Confirm all actions passing

The nocoverage, coverage, report, and check tox tasks all ran through
successfully.  I was able to build the HTML-format docs and the contents looked
good.
@jared321 jared321 self-assigned this Oct 8, 2025
@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2025

Codecov Report

❌ Patch coverage is 78.09524% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.75%. Comparing base (ea348cd) to head (afe173b).

Files with missing lines Patch % Lines
...scoxpro_pypkg/src/bfrescoxpro/print_information.py 61.11% 21 Missing ⚠️
bfrescoxpro_pypkg/src/bfrescoxpro/information.py 85.71% 1 Missing ⚠️
...frescoxpro_pypkg/src/bfrescoxpro/run_simulation.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
+ Coverage   49.31%   58.75%   +9.43%     
==========================================
  Files          10       17       +7     
  Lines         219      320     +101     
==========================================
+ Hits          108      188      +80     
- Misses        111      132      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jared321 jared321 merged commit 2593734 into main Oct 9, 2025
77 checks passed
This was referenced Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants