Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
=======================================
Coverage 58.75% 58.75%
=======================================
Files 17 17
Lines 320 320
=======================================
Hits 188 188
Misses 132 132 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Self review;
This branch has basically no functionality on it so this is very simple. |
jared321
left a comment
There was a problem hiding this comment.
- Reviewed all changes made in branch
- Please see comments/questions.
- Built both the HTML and PDF output locally with tox and reviewed rendered content
- The API docs do not reflect the alpha release's interface. Therefore, after this PR is merged,
mainwill likely need to be merged intofeature-templatesand RTD setup so that "latest" corresponds to the contents of that branch.
- The API docs do not reflect the alpha release's interface. Therefore, after this PR is merged,
- No typos found with the
typostool - Followed links in rendered docs and confirmed correct.
- The Jupyter book links show content that is not based on contents in the
feature-templates. Therefore, that branch will need to be updated for the alpha release so that it publishes its contents to the public Jupyter book
- The Jupyter book links show content that is not based on contents in the
If links are added/updated, please check them manually before merging.
|
|
||
|
|
||
| The `Configuration` class encapsulates a particular |frescox| input | ||
| configuration. `Configuration.from_template` reads in a file like the one above, |
There was a problem hiding this comment.
Both Configuration and Configuration.from_template should be changed to something like :py:class:... once this file is merged with the fully developed Configuration class.
|
@beykyle During the self review, did you test the |
I will do this after merge into |
First crack at fleshing out documentation