Skip to content

fleshing out docs#32

Merged
beykyle merged 9 commits intomainfrom
docs
Nov 14, 2025
Merged

fleshing out docs#32
beykyle merged 9 commits intomainfrom
docs

Conversation

@beykyle
Copy link
Contributor

@beykyle beykyle commented Oct 31, 2025

First crack at fleshing out documentation

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.75%. Comparing base (0c8adfd) to head (bf5a09c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #32   +/-   ##
=======================================
  Coverage   58.75%   58.75%           
=======================================
  Files          17       17           
  Lines         320      320           
=======================================
  Hits          188      188           
  Misses        132      132           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@manuelcatacora manuelcatacora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me.

@beykyle
Copy link
Contributor Author

beykyle commented Nov 11, 2025

Self review;

  • checked out installed and tested code in clean conda env following user guide
  • built docs locally and read through them

This branch has basically no functionality on it so this is very simple.

Copy link
Contributor

@jared321 jared321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Reviewed all changes made in branch
    • Please see comments/questions.
  • Built both the HTML and PDF output locally with tox and reviewed rendered content
    • The API docs do not reflect the alpha release's interface. Therefore, after this PR is merged, main will likely need to be merged into feature-templates and RTD setup so that "latest" corresponds to the contents of that branch.
  • No typos found with the typos tool
  • Followed links in rendered docs and confirmed correct.
    • The Jupyter book links show content that is not based on contents in the feature-templates. Therefore, that branch will need to be updated for the alpha release so that it publishes its contents to the public Jupyter book

If links are added/updated, please check them manually before merging.



The `Configuration` class encapsulates a particular |frescox| input
configuration. `Configuration.from_template` reads in a file like the one above,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both Configuration and Configuration.from_template should be changed to something like :py:class:... once this file is merged with the fully developed Configuration class.

@jared321
Copy link
Contributor

@beykyle During the self review, did you test the pro package installation procedure on one system but with two different MPI implementations? For example, install with Open-MPI first and MPICH a second time? With Taweret, we ran into issues with cached prebuilt wheels. mpi4py docs mention this issue as well.

@beykyle
Copy link
Contributor Author

beykyle commented Nov 14, 2025

@beykyle During the self review, did you test the pro package installation procedure on one system but with two different MPI implementations? For example, install with Open-MPI first and MPICH a second time? With Taweret, we ran into issues with cached prebuilt wheels. mpi4py docs mention this issue as well.

I will do this after merge into feature-templates, in case there is any difference, so that we can verify it works for the branch of the alpha

@beykyle beykyle merged commit 2e69dc9 into main Nov 14, 2025
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants