Skip to content

Conversation

@Marca23
Copy link
Contributor

@Marca23 Marca23 commented Nov 4, 2025

Implementation details

  • Add Band source

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the GitHub PR explorer)

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces Band data source integration to the Bothan system and modernizes string formatting across the codebase by replacing verbose format placeholders ({}) with inline variable syntax ({variable}).

Key Changes:

  • Adds new bothan-band module with REST API client and worker implementation for Band data source
  • Integrates Band workers into the core manager and configuration system
  • Updates string formatting throughout the codebase to use inline format syntax

Reviewed Changes

Copilot reviewed 25 out of 26 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
bothan-band/* New Band integration module including API client, worker, and types
bothan-core/src/manager/crypto_asset_info/* Adds Band worker variant to enum and integration logic
bothan-core/Cargo.toml Adds bothan-band dependency
bothan-api/server/src/config/manager/crypto_info/sources.rs Adds Band worker configuration options (band1, band2)
bothan-api/server/cli/src/commands/start.rs Initializes Band worker options
Various files Modernizes format strings to inline syntax

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@RogerKSI RogerKSI requested a review from Copilot November 4, 2025 10:38
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 26 out of 27 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@RogerKSI RogerKSI requested a review from Copilot November 4, 2025 10:52
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 26 out of 27 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@RogerKSI RogerKSI requested a review from Copilot November 5, 2025 10:02
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 27 out of 28 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@RogerKSI RogerKSI self-requested a review November 6, 2025 07:26
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 28 out of 30 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 35 out of 37 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 35 out of 37 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 36 out of 38 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bandprotocol bandprotocol deleted a comment from Copilot AI Nov 13, 2025
@bandprotocol bandprotocol deleted a comment from Copilot AI Nov 13, 2025
@bandprotocol bandprotocol deleted a comment from Copilot AI Nov 13, 2025
@RogerKSI RogerKSI merged commit a87e2eb into main Nov 13, 2025
9 checks passed
@RogerKSI RogerKSI deleted the band-source branch November 13, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants