Skip to content

Refactor Hooks (by Bun)#85

Merged
taobun merged 2 commits intomasterfrom
bun/refactor-hooks
May 31, 2021
Merged

Refactor Hooks (by Bun)#85
taobun merged 2 commits intomasterfrom
bun/refactor-hooks

Conversation

@ntchjb
Copy link
Copy Markdown
Contributor

@ntchjb ntchjb commented May 27, 2021

Fixed: -

Implementation details

Refactor Hooks to use Hooks type to represent a list of Hook. This makes the code less coupling.

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@ntchjb ntchjb requested review from Benzbeeb, songwongtp and taobun May 27, 2021 09:47
@taobun taobun merged commit e9ff406 into master May 31, 2021
@taobun taobun deleted the bun/refactor-hooks branch May 31, 2021 03:37
taobun added a commit that referenced this pull request May 31, 2021
vuong177 pushed a commit to vuong177/chain that referenced this pull request Feb 5, 2022
* fix link (bandprotocol#250)

* Update outdated documentation (bandprotocol#252)

* fix bandprotocol#85

* fix bandprotocol#77

* add genesis restart docs (bandprotocol#247)

* add genesis restart docs

* add small note

* bump SDK dep to v0.43.0-rc1 (bandprotocol#254)

* update changelog dates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants