Skip to content

Yoda Fix No-Reuse Account Information#91

Merged
ntchjb merged 1 commit intomasterfrom
nathachai/yoda-fix-account-attempt
Jun 2, 2021
Merged

Yoda Fix No-Reuse Account Information#91
ntchjb merged 1 commit intomasterfrom
nathachai/yoda-fix-account-attempt

Conversation

@ntchjb
Copy link
Copy Markdown
Contributor

@ntchjb ntchjb commented Jun 1, 2021

Fixed: -

The account got from BandChain node has been reused, which should not happen. When there is out-of-gas scenario and trying to do another attempt, same account information has been used. However, sequence number of the account already changed and account information should be updated.

Otherwise, when sending the transaction, it will be rejected during CheckTx, and Yoda is unable to fetch the transaction status from BandChain

Implementation details

Every time when need account information, it should be always queried from BandChain node without reusing it.

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@ntchjb ntchjb requested review from Benzbeeb and taobun June 1, 2021 06:58
Copy link
Copy Markdown
Member

@taobun taobun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taobun taobun requested a review from songwongtp June 2, 2021 03:51
@ntchjb ntchjb merged commit 5fa67b5 into master Jun 2, 2021
@ntchjb ntchjb deleted the nathachai/yoda-fix-account-attempt branch June 2, 2021 07:27
ntchjb added a commit that referenced this pull request Jun 2, 2021
…ttempt

Yoda Fix No-Reuse Account Information
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants