Merged
Conversation
songwongtp
approved these changes
Jun 2, 2021
ntchjb
added a commit
that referenced
this pull request
Jun 2, 2021
…ttempt Yoda Fix No-Reuse Account Information
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed: -
The account got from BandChain node has been reused, which should not happen. When there is out-of-gas scenario and trying to do another attempt, same account information has been used. However, sequence number of the account already changed and account information should be updated.
Otherwise, when sending the transaction, it will be rejected during CheckTx, and Yoda is unable to fetch the transaction status from BandChain
Implementation details
Every time when need account information, it should be always queried from BandChain node without reusing it.
Please ensure the following requirements are met before submitting a pull request:
CHANGELOG_UNRELEASED.mdFiles changedtab in the Github PR explorer)