Skip to content

Conversation

@tanut32039
Copy link
Contributor

📝 Summary

This PR [adds/modifies/deletes] the <Signal ID> signal in the registry.

🔄 Changes Introduced

  • [Added/Modified/Deleted] <Signal ID>:
    • Source ID: <source_id>, ID: <id>, Routes: <routes> (if applicable)
  • [If applicable] Added/Updated prefix configuration in prefix/<prefix>.yaml.
  • [If applicable] Removed <Signal ID> and ensured no unresolved dependencies.

📌 Band Signaling Hub Proposal

📎 Proposal Link: [Insert Forum Link Here]

✅ Checklist

  • Provided a valid Band Signaling Hub Proposal link.
  • Added/Updated the signal file in the appropriate signals/<prefix>/ directory.
  • Verified that any referenced prerequisite signals exist in the registry.
  • Ensured no circular dependencies are introduced.
  • [If applicable] Updated prefix configuration in prefix/<prefix>.yaml.
  • [If applicable] Updated documentation to reflect the new/modified signal.
  • [If applicable] For deleted signals: Verified that the deleted signal is not a dependency for other signals, or resolved any affected dependencies.

@RogerKSI RogerKSI requested review from Marca23 and Copilot November 9, 2025 14:19
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds two new Band Protocol data sources (band1 and band2) to the CS (CoinStats) signal configurations. The changes ensure these sources are included in the price aggregation for all supported cryptocurrency pairs.

Key changes:

  • Added band1 and band2 as new data sources with weight 1 in the main CS configuration
  • Added these two sources to all existing cryptocurrency pair YAML files
  • Added new data sources from various exchanges (Bybit, Coinbase, Kraken, OKX) for several trading pairs

Reviewed Changes

Copilot reviewed 201 out of 201 changed files in this pull request and generated 2 comments.

File Description
signals/CS.yaml Added band1 and band2 sources with weight 1 to processor configuration
signals/CS/*.yaml (200+ files) Added band1 and band2 source entries to all cryptocurrency pair configurations
Various new exchange sources Added additional trading pair sources across Binance, Bybit, Coinbase, Kraken, and OKX exchanges

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@RogerKSI RogerKSI requested a review from Copilot November 9, 2025 15:17
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 201 out of 201 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@RogerKSI RogerKSI merged commit 2a5e430 into main Nov 12, 2025
1 check passed
@RogerKSI RogerKSI deleted the add-band-source branch November 12, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants