systemcontract: update compiler version #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnnaShaleva
reviewed
May 30, 2024
| // OpenZeppelin Contracts (last updated v5.0.0) (proxy/ERC1967/ERC1967Proxy.sol) | ||
|
|
||
| pragma solidity ^0.8.20; | ||
| pragma solidity ^0.8.25; |
Member
There was a problem hiding this comment.
We need to ensure that this compiler version does not include unsupported opcodes like it was with #113.
Contributor
Author
There was a problem hiding this comment.
MCOPY is introduced in 0.8.24 and 0.8.25, but I don't think we are using it. Actually, we compiled the old contracts with version 0.8.24, so there is only 1 version gaps. May refer to https://soliditylang.org/blog/2024/03/14/solidity-0.8.25-release-announcement.
Anyway, we will upgrade and test a local network before T3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #206.