fix(grove): respect configured base branch during source repo sync#57
Merged
bang9 merged 1 commit intobang9:mainfrom Apr 2, 2026
Merged
fix(grove): respect configured base branch during source repo sync#57bang9 merged 1 commit intobang9:mainfrom
bang9 merged 1 commit intobang9:mainfrom
Conversation
refresh_source_repo() always used remote_default_branch(), ignoring the user's base_branch setting. Pass base_branch into the function and use it when the branch exists on remote, falling back to auto-detect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
refresh_source_repo()가 항상remote_default_branch()만 호출하여 사용자가 설정한base_branch를 무시하던 버그 수정base_branch: Option<&str>파라미터를 추가하고, 설정된 경우 해당 브랜치를 사용 (리모트에 없으면 auto-detect fallback)add_worktree(line ~1036)에서 이미 사용 중인 동일한 show-ref/verify 패턴 적용Test plan
refresh_project_uses_configured_base_branch_instead_of_remote_default추가 (TDD red→green)