Skip to content

Conversation

@matthewmayer
Copy link
Contributor

@matthewmayer matthewmayer commented Mar 8, 2019

What happened

Unclear what "get location" would do. "view map" seems clearer it links to google maps

Insight

N/A

Proof Of Work

home___ruby_conference_thailand_2019

@matthewmayer matthewmayer changed the base branch from master to development March 8, 2019 12:42
@olivierobert olivierobert changed the title i think “view map” is a clearer button name than “get location” Replace text "Get Location" by "View Map' Mar 8, 2019
@olivierobert olivierobert added this to the 0.3.1 milestone Mar 8, 2019
Copy link
Contributor

@olivierobert olivierobert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the PR description. No issues to change the text.

@olivierobert olivierobert merged commit a6e5bbf into development Mar 8, 2019
@olivierobert olivierobert deleted the bug/view-map branch March 8, 2019 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants