fix: remove redundant province data from latest_case in province list API #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… API - Add TransformToResponseWithoutProvince methods to ProvinceCase models - Update GetProvincesWithLatestCase service to use new transformation - Remove duplicate province information from latest_case object - Maintain backward compatibility for other endpoints - Add comprehensive test coverage for new transformation methods The province list API now returns cleaner data structure without redundant province information in the latest_case object.
Contributor
📊 Code Coverage ReportTotal Coverage: 49.9% Coverage by Package
Detailed CoverageClick to expand detailed coverage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the province list API by removing redundant province information from the
latest_caseobject, creating a cleaner and more efficient response structure.Problem
The
/api/v1/provincesendpoint was returning duplicate province data:latest_caseobjectSolution
TransformToResponseWithoutProvince()methods toProvinceCasemodelsGetProvincesWithLatestCase()service to use the new transformationChanges
Before
{ "id": "72", "name": "Sulawesi Tengah", "latest_case": { "day": 123, "date": "2024-01-01", "province": { "id": "72", "name": "Sulawesi Tengah" // ❌ Redundant! } } }After
{ "id": "72", "name": "Sulawesi Tengah", "latest_case": { "day": 123, "date": "2024-01-01", "daily": { ... }, "cumulative": { ... } // ✅ Clean structure without redundancy } }Testing
Impact