fixing travis build #504
Merged
fixing travis build #504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* const is not a type that psalm recognises * declaring a psalm-type with the supported consts hardcoded might not be preferrable in the long-run * a method with a scalar return type whose body returns null should not use a non-nullable scalar return type
one does not need to perform a conditional return for falsey types if one returns inside a try-catch loop against an object constructor.
properties not initialised in a class constructor that have no default value need to be nullable.
bapcltd-marv
force-pushed
the
fixing/travis-build-2020-05-18
branch
from
ebc822d to
8cee644
Compare
This was referenced May 19, 2020
Collaborator
|
@bapcltd-marv did you see my review comment? :) |
Contributor
Author
|
nope? i.e. didn't see any notification about a review comment and it may have disappeared when I did a force-push (which they normally don't?) |
1 task
SignpostMarv
pushed a commit
to bapcltd/php-imap
that referenced
this pull request
May 25, 2020
SignpostMarv
pushed a commit
to bapcltd/php-imap
that referenced
this pull request
May 25, 2020
markovlatkovic
added a commit
to markovlatkovic/php-imap
that referenced
this pull request
May 24, 2024
Patrici97
added a commit
to Patrici97/php-imap
that referenced
this pull request
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hadn't noticed these until I was rebasing for our drop/php-7.3 branch.
this pr fixes the travis build failures caused by recent commits.
currently feeling unsure about the
psalm-typeintroduced in 332aebf, thoughts?