-
-
Notifications
You must be signed in to change notification settings - Fork 21
Add multi-tab support with keyboard shortcuts and per-tab exports #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: barelyhuman <43572006+barelyhuman@users.noreply.github.com>
Co-authored-by: barelyhuman <43572006+barelyhuman@users.noreply.github.com>
Co-authored-by: barelyhuman <43572006+barelyhuman@users.noreply.github.com>
…improve input focusing Co-authored-by: barelyhuman <43572006+barelyhuman@users.noreply.github.com>
…bility Co-authored-by: barelyhuman <43572006+barelyhuman@users.noreply.github.com>
|
Tabs and Sidebar arent visible in the screenshot |
… collapse Co-authored-by: barelyhuman <43572006+barelyhuman@users.noreply.github.com>
Fixed in commit 7fff54f. The sidebar was collapsing to 1px width due to flex layout. Added Updated screenshots now show the sidebar clearly: |
src/components/sidebar.vue
Outdated
| const tabs = tabsState.tabs; | ||
| const activeTabId = ref(tabsState.activeTabId); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot is the additional derivative state needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right - the derivative state wasn't needed. Removed the activeTabId ref, the watcher, and all manual syncing in commit 1c5bab8. Now using tabsState.activeTabId directly in the template, which is already reactive.
Co-authored-by: barelyhuman <43572006+barelyhuman@users.noreply.github.com>
Implementation Plan for Tab Functionality
Features to Implement:
Summary
Successfully implemented tab functionality for the Mark markdown editor with the following features:
✅ Implemented Features:
Tab Management System
src/stores/tabs.js) that manages multiple markdown filesSidebar Component
Keyboard Shortcuts
Cmd/Ctrl + T: Create new tabCmd/Ctrl + W: Close current tabCmd/Ctrl + 1-9: Switch to specific tab by numberPer-Tab Export Functionality
Code Quality & Security:
Screenshots:
Technical Implementation:
tabsStatedirectly without unnecessary derivative stateSecurity Summary:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.