Skip to content

tweak(ui): simplify picker prompts#115

Merged
barrettruth merged 4 commits intomainfrom
fix/reliable-browse-and-pickers
Apr 9, 2026
Merged

tweak(ui): simplify picker prompts#115
barrettruth merged 4 commits intomainfrom
fix/reliable-browse-and-pickers

Conversation

@barrettruth
Copy link
Copy Markdown
Owner

Summary

  • align picker prompts around state, scope, and count across PRs, issues, checks, CI, releases, branches, commits, worktrees, review, and templates
  • normalize GitLab UI labels from MR wording to PR wording while keeping the underlying glab mr transport unchanged
  • carry forward the list-signature type fix so the load-more picker flow stays clean under Lua LS

Test plan

  • stylua --check lua/forge/init.lua lua/forge/gitlab.lua lua/forge/pickers.lua lua/forge/review.lua spec/fzf_picker_spec.lua spec/git_sections_spec.lua spec/pickers_spec.lua spec/review_spec.lua spec/sources_spec.lua
  • selene lua/forge/init.lua lua/forge/gitlab.lua lua/forge/pickers.lua lua/forge/review.lua
  • busted spec

GitHub browse could fail silently, large issue and PR lists had no way to fetch more entries, and embedded control characters in issue titles could break picker rows.

Route GitHub browse through URL resolution plus vim.ui.open, add explicit load-more rows for issue and PR pickers, and normalize control characters during picker rendering.
Keep Lua LS in sync with the optional fetch limit used by
picker load-more requests so typecheck accepts the new calls.
Keep picker titles focused on state, scope, and count so they read
consistently across lists, checks, CI, releases, review, and templates.
This also normalizes GitLab UI labels to PR wording and hardens the
review spec for combined runs.
@barrettruth barrettruth merged commit c1533c2 into main Apr 9, 2026
8 checks passed
@barrettruth barrettruth deleted the fix/reliable-browse-and-pickers branch April 9, 2026 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant