refactor: canonicalize logging into logger module#14
Merged
barrettruth merged 2 commits intomainfrom Mar 29, 2026
Merged
Conversation
Problem: logging was scattered across 36 raw `vim.notify()` calls with inconsistent prefixes (`[forge]` vs `[forge.nvim]`), missing levels, no debug mode, and silent failures on JSON decode errors. Solution: introduce `forge.logger` with `debug`/`info`/`warn`/`error` helpers, a `debug` config option (`boolean` or file path), and replace every call site. Downgrade internal-detail messages to debug-only. Add error handling for PR and issue list fetch failures. Add debug logging to `detect()` for diagnosing forge resolution. Fix `._by_name` bug in `:Forge pr` dispatch, add missing `refresh` action to checks picker, and pass `job_id` to `check_log_cmd` for per-check log filtering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Logging was scattered across 36 raw
vim.notify()calls with inconsistent prefixes ([forge]vs[forge.nvim]), 6 calls missing log levels, 2 silent failure paths (PR/issue list JSON decode), and no debug mode.Solution
Introduce
forge.loggermodule withdebug()/info()/warn()/error()helpers and adebugconfig option (booleanforvim.notifydebug output,stringfor file logging). Replace every rawvim.notify('[forge]...')call site across all 7 files. Downgrade 4 internal-detail messages to debug-only. Add error handling for PR and issue list fetch failures. Add debug logging todetect().Also fixes:
._by_namebug in:Forge prdispatch, missingrefreshaction in checks picker, and per-check log showing all run logs instead of the selected job.Closes #4