feat(target): parse Forge repo and revision addresses#150
Merged
barrettruth merged 1 commit intomainfrom Apr 11, 2026
Merged
Conversation
Add a dedicated target parser for repo, revision, and location addresses so normalized Forge commands can carry typed target data instead of raw strings. This also threads parsed target modifiers into the command layer to prepare the next stage of explicit target resolution and dispatch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The normalized
:Forgecommand layer still treats target-bearing modifiers likerepo=,rev=,target=,head=, andbase=as raw strings. That makes it impossible to carry explicit repo/revision/location intent through the command object cleanly.Solution
Add a dedicated
forge.targetmodule that parses repo, revision, and location addresses, including alias-first repo resolution order. Thread those parsed target objects intoforge.cmd.parse()so normalized commands now expose typed target data underparsed_modifiers.