fix(pr-create): guard web flow with base preflights#190
Merged
barrettruth merged 1 commit intomainfrom Apr 12, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
:Forge pr create webcould still push and open the browser flow in cases that normal PR creation already should reject, especially when the current branch already matched the effective base branch or there were no changes fromorigin/<base>.Solution
Reuse the same base-resolution and creatability checks before the web flow pushes or opens the browser. This keeps valid same-origin PR creation working, blocks branch==base, and blocks no-diff cases. The PR also removes a stale
|forge-review|vimdoc tag reference so CI passes.