fix(fzf): let picker selection highlight win over metadata#233
Merged
barrettruth merged 1 commit intomainfrom Apr 13, 2026
Merged
fix(fzf): let picker selection highlight win over metadata#233barrettruth merged 1 commit intomainfrom
barrettruth merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Highlighted picker segments can carry their own background ANSI through
ansi_from_hl(), which lets row metadata like issue authors override the selected-row background in fzf-lua. The current renderer only strips backgrounds for a small branch-specific allowlist, so the same cursorline bug still shows up on usernames and other metadata segments.Solution
Strip background ANSI from all highlighted entry segments in the shared fzf picker renderer so the selected row highlight wins consistently across issue, PR, commit, worktree, CI, and related picker rows. Add a regression spec that covers author and metadata segments in addition to the existing branch-focused case.