refactor(picker): share session json request flow#246
Merged
barrettruth merged 3 commits intomainfrom Apr 13, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
forge.picker.sessionhandles a fair amount of async request and invalidation logic, but its JSON request flow is duplicated between prefetch and picker-open paths. The module also has very little direct unit coverage, which makes it harder to refactor safely when picker behavior changes.Solution
Extract the shared JSON request lifecycle into one helper and keep the stale-request handling behavior explicit at each call site. Add focused unit tests for decode behavior, prefetch skipping and invalidation, cached opens, streamed picker success and failure, and stale streamed requests.