fix(browse): simplify direct browse targeting#247
Merged
barrettruth merged 1 commit intomainfrom Apr 14, 2026
Merged
Conversation
Keep direct browse focused on the current file or repo root instead of a custom repo/rev/path address language, and make special buffers fall back to repo or revision roots predictably. Also scope two compose locals introduced on origin/main so the branch passes CI cleanly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
:Forge browsehad grown a custom address language that mixed repo, revision, file, and range targeting in ways that felt foreign for the common case. It also behaved badly in special buffers by trying to derive file context where none existed.Solution
Reduce direct browse to the common cases: browse the current file, optionally on a plain
rev=, and fall back to the repo or revision root when there is no real file buffer. The command docs, completion, parsing, dispatch, and tests now match that smaller interface. This also scopes two leaked compose locals frommainso the branch passes CI cleanly.