fix: redraw before notify and warn on unsupported capability paths#320
Merged
barrettruth merged 1 commit intomainfrom Apr 18, 2026
Merged
fix: redraw before notify and warn on unsupported capability paths#320barrettruth merged 1 commit intomainfrom
barrettruth merged 1 commit intomainfrom
Conversation
Logger notified before redrawing, which could wipe messages while the fzf-lua terminal window was active. Redraw first so the message lands after the terminal settles. Also reclassify picker-level unavailable/unsupported capability paths from info to warn: - logs not available, use browse to view - no log available - job was not started - structured checks not available for this forge - structured CI data not available for this forge Closes #281 Closes #291
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In fzf-lua terminal mode, top-level warnings and picker-local notifications were easy to miss. Two underlying issues: the logger was calling
vim.notifyand thenvim.cmd.redraw(), which is the exact ordering Neovim docs warn about (:help :echo-redraw) because a later redraw can wipe the message. Separately, several picker-level capability failures were emitted asinforather thanwarn, so genuine lack-of-support conditions were presented at the lowest severity.Solution
Flip the logger to redraw before notifying so the message lands after the terminal settles, and upgrade four capability-failure paths in
lua/forge/pickers.luafrominfotowarn: missing check log URL, skipped-check job, no structured checks support, and no structured CI support. Specs updated accordingly and two new picker specs cover the unsupported structured-checks and structured-CI branches. Closes #281 and #291.