Make review the canonical PR command surface#333
Merged
barrettruth merged 2 commits intomainfrom Apr 19, 2026
Merged
Conversation
Unify PR entrypoints around adapter-backed review so checkout, worktree, and browse stop duplicating the Ex command surface. This keeps integrations behind the review abstraction while preserving picker behavior, adapter extensibility, and the existing verification coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Forge's PR Ex surface repeated the same intent through multiple concrete verbs.
:Forge pr checkout,:Forge pr worktree, and:Forge pr browseall exposed adapter mechanics directly, even though the plugin's user-facing concept is reviewing a PR.Solution
Introduce a review adapter layer and make
:Forge review {num}the canonical PR command entrypoint. This keeps checkout, worktree, and browser behavior behind adapter dispatch, removes the redundant PR Ex verbs and wrapper ops, updates picker/config/API surfaces to match, and refreshes the specs and vimdoc around the new model. Verification ran withnix develop .#ci --command bustedandnix develop .#ci --command vimdoc-language-server check doc/.