feat(review): add diffview adapter#349
Merged
barrettruth merged 2 commits intomainfrom Apr 20, 2026
Merged
Conversation
Provide a first built-in external review integration so Forge can open pull requests in diffview.nvim without checking out the branch. This also teaches healthcheck and completion about adapter availability so review integrations have a complete user-facing path.
Bring the README and health spec in line with the repo's markdown and Lua formatting checks so the diffview adapter PR passes the remaining quality jobs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Forge has the canonical
:Forge reviewcommand surface now, but it still needs a first real external adapter to prove the no-checkout review path in the main repo.diffview.nvimis the simplest first built-in integration for that model and is tracked in #347.Solution
Add a built-in
diffviewreview adapter that fetches the PR head into a hidden Forge ref and opens:DiffviewOpen <base>...<head>without checking the branch out.Update health reporting so built-in external review adapters are surfaced cleanly, optional integrations stay informational, and a configured-but-missing
diffviewadapter warns.Document the adapter in the README and vimdoc, add focused review/health/completion specs, and verify with
nix develop /home/barrett/dev/forge.nvim#ci --command bustedplusnix develop /home/barrett/dev/forge.nvim#ci --command vimdoc-language-server check /home/barrett/dev/forge.nvim/doc/.Closes #347