refactor(cmd): extract completion policy model#351
Merged
barrettruth merged 2 commits intomainfrom Apr 20, 2026
Merged
Conversation
Centralize stock cmdline completion policy so later cmdline contract changes can apply shared rules without spreading more ad hoc branching.
This was referenced Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Cmdline completion policy is currently split across
forge.cmd, picker availability helpers, and picker semantics, which makes the stock Ex surface easy to drift as the cmdline contract evolves. Closes #338.Solution
Extract
lua/forge/completion_policy.luaas the shared stock-cmdline policy source, routeforge.cmdsubject and modifier-value completion decisions through it, and add focused specs for the new policy module.