fix(review): honor integration labels in picker header#357
Merged
barrettruth merged 1 commit intomainfrom Apr 20, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Forge's review adapter integrations show up through the canonical
adapter=flow, but the PR picker's default review action still resolves its visible label without row context. That means built-in integrations were only implicitly covered, and registered/custom adapters that provide a functionallabel(ctx)could appear in adapter completion while still rendering the wrong picker header label.Solution
Pass the highlighted PR entry through the review-label helper so the picker can resolve adapter labels from a real review context.
Teach
forge.review.label(...)to safely evaluate functional adapter labels when a full review context is available, while preserving the old string-label fallback when only config/options are known.Add picker and command specs that cover configured integration labels, registered functional adapter labels, and registered adapter completion parity.
Locally verified with changed-file
stylua, changed-fileselene,lua-language-server --check lua, focusedbustedfor picker/command specs, and fullbusted(567 successes / 0 failures / 0 errors).Closes #350