fix(review): stop worktree opens after fetch failure#440
Merged
barrettruth merged 1 commit intomainfrom Apr 26, 2026
Merged
Conversation
The worktree review adapter was still starting git worktree add even when the preceding PR fetch failed, which hid the real fetch error behind a later worktree failure. Stop after fetch errors and surface the underlying command failure instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The review worktree adapter was still starting
git worktree addeven when the preceding PR fetch failed. That hid the real fetch error and could replace it with a misleading later worktree failure.Closes #434.
Solution
Check the fetch result first, surface the real fetch failure, and only run
git worktree addafter a successful fetch. Add focused review specs that cover both the successful worktree path and the fetch-failure guard.