resolver: add branch-relative non-open PR lookup beside current_pr()#457
Merged
barrettruth merged 1 commit intomainfrom Apr 27, 2026
Merged
resolver: add branch-relative non-open PR lookup beside current_pr()#457barrettruth merged 1 commit intomainfrom
barrettruth merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
current_pr()is intentionally open-only, but Forge did not have a second branch-relative PR resolver for workflows that need to recover a unique PR for the current branch across non-open states. That blocked follow-up features like implicitpr reopenand broader implicitpr_ci()fallback without muddying the open-only semantics used bypr(),review(), and create-PR duplicate detection.Solution
Add
require('forge.resolve').branch_pr()with ordered state-search passes, and keepcurrent_pr()as a thin open-only wrapper on top of it. Extend backend branch lookup commands so GitHub, GitLab, and Codeberg can enumerate branch PR candidates under broader state policies, normalize fetched PR detail state so merged PRs stay distinct from merely closed ones, and add resolver/source specs that cover open-only preservation, fallback policy ordering, ambiguity, and backend-specific matching behavior.Closes #453.