fix: resolve treesitter overlay conflict and improve highlight links#60
Merged
barrettruth merged 1 commit intomainfrom Apr 5, 2026
Merged
fix: resolve treesitter overlay conflict and improve highlight links#60barrettruth merged 1 commit intomainfrom
barrettruth merged 1 commit intomainfrom
Conversation
Use inline hl_group at priority 150 for compose comment block instead of line_hl_group alone. This overrides treesitter's @comment captures (priority 100) while still yielding to metadata extmarks (priority 200). Restore ForgeComposeComment = Comment now that the conflict is resolved. Switch ForgeLogError and ForgeLogWarning from DiagnosticVirtualText variants to DiagnosticError/DiagnosticWarn — the VirtualText groups carry a background tint that looks odd as line highlights. Closes #58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
line_hl_group-only extmarks on compose comment block with inlinehl_group+line_hl_groupat priority 150. This overrides treesitter's@commentcaptures (priority 100) while yielding to metadata extmarks (priority 200).ForgeComposeComment = 'Comment': The{ italic = true }workaround is no longer needed now that the inline highlight properly overrides treesitter.ForgeLogErrorandForgeLogWarningfromDiagnosticVirtualTextError/DiagnosticVirtualTextWarntoDiagnosticError/DiagnosticWarn— the VirtualText variants carry a background tint that looks odd as line highlights.Closes #58
Test plan
Commenthighlight, metadata labels override it<!-- ... -->block