Harden private key handling to prevent potential leaks#10
Merged
Conversation
- Disable Android backup to prevent EncryptedSharedPreferences extraction - Redact privkey from Keypair toString(), use pubkey for hashCode() - Add ByteArray.wipe() extension and use it to zero throwaway keys in NIP-17 - Clear nsec from Compose state on dispose to minimize memory exposure - Mark clipboard as sensitive on API 33+ when copying private key - Zero conversation keys on LruCache eviction in DmRepository
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
allowBackup="false") to prevent EncryptedSharedPreferences from being extracted via adb backup or Auto BackupKeypairclass — redact privkey fromtoString(), derivehashCode()from pubkey only, addwipe()methodByteArray.wipe()extension and use it to zero throwaway keys and conversation keys after use in NIP-17 gift wrap creationDisposableEffectnulls out the revealed nsec string when the KeysScreen composable leaves compositionentryRemoved()on conversation key cache to zero evicted byte arraysTest plan
adb backupproduces empty/no backup🤖 Generated with Claude Code