fix: preserve feed scroll position when navigating back#190
Merged
Conversation
barrydeen
force-pushed
the
fix/feed-scroll-position
branch
from
b477e28 to
7405d45
Compare
The LaunchedEffect that scrolls to top on feed type changes was firing on every recomposition, including after back-navigation from thread or compose screens. Track previous values so scroll-to-top only triggers when the feed type, list, relay, or relay set actually changes.
barrydeen
force-pushed
the
fix/feed-scroll-position
branch
from
7405d45 to
0670063
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LaunchedEffectinFeedScreenwas unconditionally scrolling to top on every recomposition, including after back-navigation — now it tracks previous values and only scrolls to top when the feed type, list, relay, or relay set actually changesTest plan