Add media loading and video autoplay settings#219
Merged
Conversation
Add two new toggles in Interface Settings: - Auto-load media: when off, images/videos show a tap-to-load placeholder - Video autoplay: when off, videos load but don't auto-play on scroll Uses CompositionLocal to provide settings down the tree without threading parameters through every call site.
barrydeen
force-pushed
the
feat/media-settings
branch
from
81ee2fe to
2649104
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CompositionLocal(LocalMediaSettings) to provide settings down the composable tree, avoiding parameter threading through every call sitetrue, preserving current behaviorTest plan