fix: update signer when switching between LOCAL accounts#270
Merged
Conversation
When switching between two LOCAL (nsec) accounts, the signer was not updated because signingMode (LOCAL → LOCAL) didn't change, so the remember key was identical and the cached signer was reused. Add npub as a recomposition key so the signer is always recreated on account switch, and defensively clear the signer during switch/logout to prevent stale signing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
signingModestaysLOCALsoStateFlowconflation prevents recomposition — the old signer is reused, causing posts signed by the wrong keynpubas arememberkey inNavigation.ktso the signer is always recreated on account switchclearSigner()toFeedViewModeland call it during account switch and logout to prevent stale signing during the transition windowTest plan