Conversation
…ale cooldowns When reconnectAll/forceReconnectAll evicts ephemeral relays, disconnect() triggers an async onFailure on OkHttp's thread. With reconnectEnabled still true, collectRelayFailures would write a new cooldown into relayCooldowns after the relayCooldowns.clear() call at the start of the reconnect — leaving a stale cooldown that blocked sendToRelayOrEphemeral from recreating the connection on the next search. Fix mirrors the existing pattern for persistent/DM relays: set reconnectEnabled = false before disconnect() so the failure emission is suppressed during eviction. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reconnectAll/forceReconnectAllevicts ephemeral relays,disconnect()triggers an asynconFailureon OkHttp's threadreconnectEnabledstilltrue,collectRelayFailureswould write a new cooldown intorelayCooldowns— afterrelayCooldowns.clear()already ran — leaving a stale entrysendToRelayOrEphemeral(e.g. the user searches after returning from background) hits the stale cooldown and returnsfalse, silently blocking the new ephemeral connectionFix
Set
relay.reconnectEnabled = falsebeforerelay.disconnect()in both ephemeral eviction loops, mirroring the pattern already in place for persistent and DM relays inforceReconnectAll.Test plan