Conversation
Four fixes:
1. Repost notifications (kind 6):
- Add kind 6 to notification filter
- New RepostNotification type in NotificationGroup
- Handle kind 6 in NotificationRepository.addEvent()
- Render repost notifications in NotificationsScreen
- Include in purgeUser and getAllPostCardEventIds
2. Engagement re-subscribe on soft resume:
- resumeSubscribeFeed() now calls subscribeEngagementForFeed()
after EOSE so engagement data refreshes on app resume
3. Notification engagement restored on feed refresh:
- resubscribeFeed() was clearing all engagement subs but only
re-subscribing feed engagement. Now also calls
subscribeNotifEngagement() after EOSE.
4. DM/notification subs restored on force reconnect:
- Extract subscribeDmsAndNotifications() from subscribeSelfData()
- Call it from onReconnected when force=true (forceReconnectAll
tears down all active subscriptions)
barrydeen
deleted the
fix/subscription-lifecycle-and-repost-notifications
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix missing repost notifications and subscription drops on reconnect/resume.
Changes
1. Repost notifications (kind 6)
RepostNotificationtype inNotificationGroupsealed classNotificationRepository.addEvent()handles kind 6 →mergeRepost()processRelayEvent()routes kind 6 througheventRepo.addEvent()NotificationsScreenrenders repost notifications with "{name} reposted" header + referenced PostCardpurgeUser()andgetAllPostCardEventIds()updated for new type2. Engagement re-subscribe on soft resume
resumeSubscribeFeed()now callssubscribeEngagementForFeed()after EOSE3. Notification engagement restored on feed refresh
resubscribeFeed()clears ALL engagement subs (including notification engagement) but only re-subscribed feed engagementsubscribeNotifEngagement()after EOSE so notification reaction/zap data stays live4. DM/notification subs restored on force reconnect
subscribeDmsAndNotifications()fromsubscribeSelfData()onReconnected(force=true)now calls it — previouslyforceReconnectAll()tore down all subscriptions but only feed was re-subscribed, leaving DMs and notifications deadTesting