fix: prevent scheduled posts from polluting feed and since filter#350
Merged
Conversation
Future-dated notes fetched from the scheduler relay were persisted to ObjectBox via cacheEvent(), then seeded into the feed on next boot by rebuildFeedFromCache(). Their future created_at also poisoned the latest_follows_feed_ts preference, causing the since filter to sit in the future so no new notes were ever fetched. - Skip persisting future-dated events in cacheEvent() - Filter out future-dated events in rebuildFeedFromCache() - Cap saved latest_follows_feed_ts at current time as safety net
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cacheEvent(), then seeded into the feed on next boot byrebuildFeedFromCache()— causing scheduled posts to appear in the main feedcreated_atalso poisonedlatest_follows_feed_ts, pushing thesincefilter into the future so no new notes were ever fetched on subsequent bootscacheEvent(), filter them out inrebuildFeedFromCache(), and cap the savedsincetimestamp at current time as a safety netTest plan