feat: encrypt DM media with AES-256-GCM (Kind 15)#411
Merged
Conversation
Files shared in DMs are now encrypted client-side with a random AES-256-GCM key before uploading to Blossom. The decryption key is distributed inside the NIP-17 gift wrap as a Kind 15 rumor, so only conversation participants can view the media.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
isFileMessage()helperencryptedFileMetadatafield onDmMessageuploadEncryptedMedia()encrypts then uploads via/uploadonly (skips/mediawhich would corrupt ciphertext)uploadMedia()now encrypts and sends Kind 15 viasendFileMessage()(local + remote signer)EncryptedMediaContentcomposable: download, decrypt, display with in-memory LRU cacheTest plan
/uploadendpoint is used (not/media) for encrypted blobs