Skip to content

fix: improve PiP player controls and rendering#417

Merged
barrydeen merged 2 commits intomainfrom
fix/pip-improvements
Apr 2, 2026
Merged

fix: improve PiP player controls and rendering#417
barrydeen merged 2 commits intomainfrom
fix/pip-improvements

Conversation

@barrydeen
Copy link
Copy Markdown
Owner

Summary

  • Add play/pause toggle to PiP overlay with tap-to-reveal controls (auto-hide after 2s)
  • Suppress feed video auto-play while PiP is active to prevent interference
  • Wire up missing fullscreen callback on livestream player
  • Replace PlayerView (SurfaceView) with TextureView in PiP to fix z-ordering bleed-through from inline videos

Test plan

  • Put a video in PiP, verify controls are hidden by default
  • Tap PiP to reveal play/pause, fullscreen, close — verify they auto-hide after 2s
  • Scroll feed while PiP is active — verify no other video content bleeds into PiP
  • Verify feed videos do not auto-play while PiP is active
  • Open a livestream, tap fullscreen — verify it opens the fullscreen player

barrydeen and others added 2 commits April 2, 2026 01:25
- Add play/pause button to PiP overlay
- Tap to show/hide controls with 2s auto-hide timeout
- Disable feed video auto-play while PiP is active
- Wire up fullscreen callback for livestream player
- Use TextureView instead of PlayerView to fix SurfaceView z-ordering

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@barrydeen barrydeen merged commit 706a63e into main Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant