fix: resolve live stream chat cross-platform visibility#418
Merged
Conversation
Fix dedup race between live-chat-discovery and per-stream live-chat subscriptions that silently dropped messages. Register "live-chat-" as a dedup bypass prefix so both subs independently reach EventRouter. Make ephemeral relay connections for live chat writable and auto-reconnecting so streams survive transient connection drops.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
live-chat-discoveryandlive-chat-{dTag}subscriptions both receive kind 1311 events but only one copy passed the relay pool dedup check. When discovery won the race, the event went totrackChatter()(pill counts only) instead ofaddChatMessage()— silently dropping the message from chat. Registered"live-chat-"as a dedup bypass prefix so both subs independently reach EventRouter.write=falseandautoReconnect=false, meaning they couldn't survive transient drops during long streams. Now created withwrite=true, autoReconnect=trueand released on cleanup.clearSeenEvents()call that was a workaround for the dedup issue and unnecessarily flushed the entire pool's seen-event cache.Test plan