fix: use user's emoji picker for quoted/referenced notes#490
Merged
Conversation
Quoted notes nested inside another note were using the default unicode emoji fallback instead of the user's sorted-by-frequency picker with their custom emojis. Plumb resolvedEmojis, unicodeEmojis, and the onOpenEmojiLibrary callback through NoteActions so nested PostCard / GalleryCard renders in RichContent.QuotedNote pick up the same emoji state as their parent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RichContent.QuotedNotewere showing the default 17-emoji fallback picker with no custom emoji support, instead of the user's sorted-by-frequency picker used everywhere else.resolvedEmojisProvider,unicodeEmojisProvider, andonOpenEmojiLibrarytoNoteActionsand forwarded them (plus a per-eventreactionEmojiUrls) into the nestedPostCard/GalleryCardrendered byQuotedNote.NoteActionsconstruction: FeedScreen, ThreadScreen, NotificationsScreen, UserProfileScreen, and Navigation.kt (DM, group DM, group room, hashtag, set feed, article). Providers let the already-rememberedNoteActionsread fresh StateFlow state on each invocation.Test plan