perf: avoid O(N^2) indexOf in notifications list#491
Merged
Conversation
Replace items(...) + notifications.indexOf(item) with itemsIndexed(...) in NotificationsScreen. The indexOf call ran during composition for every visible item, causing a linear scan per item and quadratic total work as the list grew. Reported as a UI freeze when tapping the notifications tab on slower devices (GrapheneOS).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LazyColumnitems { … }lambda we callednotifications.indexOf(item)on every item composition. That's a linear scan per item → O(N²) total work per recomposition pass, with each scan invokingFlatNotificationItem.equals(data class). With a few hundred notifications and frequentprofileVersionbumps invalidating the list, this is enough to stall the main thread long enough to look like a freeze on slower hardware.itemsIndexed(...)and use the suppliedindexdirectly. One-line behavioral equivalent, no more quadratic scan.Test plan
itemIndexforanimateScrollToItem) and confirm scroll-to-item still lands correctly when replying