Skip to content

feat: loop inline mp4 videos in note cards#509

Merged
barrydeen merged 1 commit intomainfrom
feat/inline-video-loop
May 4, 2026
Merged

feat: loop inline mp4 videos in note cards#509
barrydeen merged 1 commit intomainfrom
feat/inline-video-loop

Conversation

@barrydeen
Copy link
Copy Markdown
Owner

Summary

  • Inline MP4 videos rendered inside RichContent note cards now auto-repeat (Player.REPEAT_MODE_ONE).
  • Applied to both InlineVideoPlayerWithFullscreen and InlineVideoPlayer, including the PiP-reclaimed player path so reclaim from picture-in-picture also loops.
  • Fullscreen and audio playback paths are untouched.

Test plan

  • Open a note containing an MP4 — confirm it loops on completion when autoplay is on.
  • Tap to play an MP4 with autoplay disabled — confirm it loops once started.
  • Enter PiP from fullscreen, return to inline — confirm reclaimed player still loops.
  • Verify fullscreen video still ends/pauses normally (not affected by this change).
  • Verify audio playback is unchanged.

Inline video players in RichContent now use REPEAT_MODE_ONE so MP4s
auto-repeat when rendered inside a note card. Applied to both freshly
created and PiP-reclaimed players. Fullscreen and audio paths are
unchanged.
@barrydeen barrydeen merged commit 683e307 into main May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant