Conversation
Drops the embedded kmp-tor client, all .onion relay support, the Tor toggle UI on splash/auth/drawer screens, the SOCKS proxy plumbing in HttpClientFactory, all Tor-related strings across 11 locales, the TorManager singleton, and the kmp-tor dependencies and ProGuard rules. Relay URL validation now accepts only wss:// (with hostname, no port, non-localhost, non-IP). The cleartextTrafficPermitted network security flag stays — still needed for local relays on RFC1918 / loopback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.onionrelay support, Tor toggle UI (splash/auth/drawer), and Tor SOCKS plumbing fromHttpClientFactory.TorManager,TorStatus,RelayConfig.isOnionUrl/isConnectableUrl,RelayPool.swapClientAndReconnect/ensureClientCurrent,RelayLifecycleManager.onTorSwitch.ic_tor_oniondrawable, and 9 Tor-related string keys across 11 locales.wss://with a hostname (no port, no localhost, no IP).cleartextTrafficPermitted="true"stays — still needed for local (RFC1918 / loopback) relays.Test plan
./gradlew assembleDebugbuilds cleanly (no Kotlin/Lint errors)grep -rni 'TorManager|TorStatus|kmp-tor|isOnionUrl|TorRelay|ic_tor_onion|tor_enabled|\.onion'is empty acrossapp/,gradle/, READMETorManager.initializelog noisewss://relay.example.comworks;.onionURLs are rejected byisValidUrlwss://relays (no proxy applied)Notes
tor_enabledSharedPreferences key inwisp_settingsis left as a harmless orphan on devices upgraded from a prior install — no code reads it anymore.scope/launchinWispDrawerContent.kt) and one "condition is always true" inRelayPool.kt:1297are unrelated to this change.