Conversation
Restore top-level tab destinations instead of recreating them on each tap, and avoid immediately resubscribing inbox streams when users bounce between tabs. This reduces navigation jank and repeated hangs on slower devices.
7 tasks
dmnyc
pushed a commit
to dmnyc/wisp
that referenced
this pull request
May 6, 2026
PR barrydeen#514 changed the bottom-nav handler to use popUpTo with the graph's start destination plus saveState/restoreState. Two regressions resulted: - Tapping a tab restored the tab's saved back stack, returning the user to a previously-open thread instead of the tab's main screen. - The graph's start destination (LOADING) is popped inclusive on first successful load, so popUpTo never matched. The resulting back-stack state could surface the splash/auth screen on system back from Notifications. Revert that block to popUpTo(FEED) { inclusive = false } + launchSingleTop, which always lands the user on the tab's main screen with a shallow stack. The refreshDmsAndNotifications() throttle introduced alongside the broken nav block is preserved — that part addresses real REQ churn jank and is independent of how the back stack is structured.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
./gradlew assembleDebugcould not be completed in this environment because Gradle is running on Java 8 while this project requires JDK 17+