fix: filter repost notifications to only the user's own posts#52
Merged
fix: filter repost notifications to only the user's own posts#52
Conversation
Engagement subscriptions now fetch kind 6 (repost) events for all viewed posts, but EventRouter was routing all of them to NotificationRepository without checking ownership. This caused every repost on the feed to appear as a notification. Add an ownership check in EventRouter so only reposts of the user's own events are forwarded to notifications. Also add the missing kind 6 handler in the engagement branch so repost counts are tracked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
6 -> eventRepo.addEvent(event)in the engagement handler so repost counts are actually tracked from engagement subscriptionsTest plan